|
If you were logged in you would be able to see more operations.
|
|
|
|
Using Rio 4.0 M2 as provided by the Rio Installer for Windows fails when installed in the default location (Program Files). Rio is therefore likely to be broken for most Windows users. I haven't tried it on Linux, but it wouldn't be surprising if directories with spaces fail with the shell script too. (Since dirs with spaces are rare in *nix they aren't often tested.)
Any of JAVA_HOME, JINI_HOME, RIO_HOME, and the dir in which a config file resides may have spaces (the latter is actually a separate bug as it impacts Java code). In fact, in the default location on Windows all of them will.
I've created a patch that may fix the bug. If it doesn't I believe it at least makes some progress.
|
|
Description
|
Using Rio 4.0 M2 as provided by the Rio Installer for Windows fails when installed in the default location (Program Files). Rio is therefore likely to be broken for most Windows users. I haven't tried it on Linux, but it wouldn't be surprising if directories with spaces fail with the shell script too. (Since dirs with spaces are rare in *nix they aren't often tested.)
Any of JAVA_HOME, JINI_HOME, RIO_HOME, and the dir in which a config file resides may have spaces (the latter is actually a separate bug as it impacts Java code). In fact, in the default location on Windows all of them will.
I've created a patch that may fix the bug. If it doesn't I believe it at least makes some progress. |
Show » |
|
Bug
Resolved
Major
rio.cmd doesn't handle paths containing spaces
16c16
< set JINI_HOME=%RIO_HOME%\lib\apache-river
—
> set JINI_HOME="%RIO_HOME%\lib\apache-river"
28c28
< set JAVACMD=%JAVA_HOME%\bin\java.exe
—
> set JAVACMD="%JAVA_HOME%\bin\java.exe"
42c42
< rem set cliExt=%RIO_HOME%\config\rio_cli.groovy
—
> rem set cliExt=%RIO_HOME%\config\rio_cli.config
46,49c46,49
< set classpath=-cp "%RIO_HOME%\lib\rio-cli.jar";"%JINI_LIB%\jsk-lib.jar";"%JINI_LIB%\jsk-platform.jar";"%RIO_HOME%\lib\spring\spring.jar";"%RIO_HOME%\lib\jakarta-commons\commons-logging.jar";"%RIO_HOME%\lib\groovy\groovy-all-1.6.0.jar";
< set props="-DRIO_HOME=%RIO_HOME% -DJINI_HOME=%JINI_HOME%"
< "%JAVACMD%" %classpath% -Xms256m -Xmx256m ^
< -DRIO_HOME=%RIO_HOME% -DJINI_HOME=%JINI_HOME% -Djava.security.policy=%RIO_HOME%\policy\policy.all ^
—
> set classpath=-cp "%RIO_HOME%\lib\rio-cli.jar;%JINI_LIB%\jsk-lib.jar;%JINI_LIB%\jsk-platform.jar;%RIO_HOME%\lib\spring\spring.jar;%RIO_HOME%\lib\jakarta-commons\commons-logging.jar;%RIO_HOME%\lib\groovy\groovy-all-1.6-RC-1.jar"
> set props=-DRIO_HOME="%RIO_HOME%" -DJINI_HOME="%JINI_HOME%"
> %JAVACMD% %classpath% -Xms256m -Xmx256m ^
> -DRIO_HOME="%RIO_HOME%" -DJINI_HOME="%JINI_HOME%" -Djava.security.policy="%RIO_HOME%\policy\policy.all" ^
58c58
< set starterConfig="%RIO_HOME%\config\start-%1.groovy"
—
> set starterConfig="%RIO_HOME%\config\start-%1.config"
63,65c63,65
< set RIO_LOG_DIR="%RIO_HOME%"\logs\
< set RIO_NATIVE_DIR="%RIO_HOME%"\lib\native
< set PATH=%PATH%;"%RIO_NATIVE_DIR%
—
> set RIO_LOG_DIR="%RIO_HOME%\logs\"
> set RIO_NATIVE_DIR="%RIO_HOME%\lib\native"
> set PATH=%PATH%;%RIO_NATIVE_DIR%
67c67
< set classpath=-cp "%RIO_HOME%\lib\boot.jar";"%JINI_HOME%\lib\start.jar";"%JAVA_HOME%\lib\tools.jar";"%RIO_HOME%\lib\groovy\groovy-all-1.6.0.jar";
—
> set classpath=-cp "%RIO_HOME%\lib\boot.jar;%JINI_HOME%\lib\start.jar;%JAVA_HOME%\lib\tools.jar;"
73c73
< -Djava.security.policy=%RIO_HOME%\policy\policy.all ^
—
> -Djava.security.policy="%RIO_HOME%\policy\policy.all" ^
75,81c75,80
< -Djava.library.path=%RIO_NATIVE_DIR% ^
< -DJINI_HOME=%JINI_HOME% ^
< -DRIO_HOME=%RIO_HOME% ^
< -Dorg.rioproject.home=%RIO_HOME% ^
< -DRIO_NATIVE_DIR=%RIO_NATIVE_DIR% ^
< -DRIO_LOG_DIR=%RIO_LOG_DIR% ^
< -Drio.script.mainClass=%launchTarget% ^
—
> -Djava.library.path="%RIO_NATIVE_DIR%" ^
> -DJINI_HOME="%JINI_HOME%" ^
> -DRIO_HOME="%RIO_HOME%" ^
> -Dorg.rioproject.home="%RIO_HOME%" ^
> -DRIO_NATIVE_DIR="%RIO_NATIVE_DIR%" ^
> -DRIO_LOG_DIR="%RIO_LOG_DIR%" ^
87c86
< echo Cannot locate expected service starter file [start-%1.config] in [%RIO_HOME%\config], exiting"
—
> echo "Cannot locate expected service starter file [start-%1.config] in [%RIO_HOME%\config], exiting"